Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): Raise ingest error if we ever have multiple loculus accession for one insdc accession in loculus #2844

Merged
merged 2 commits into from
Sep 19, 2024
Merged

feat(ingest): Raise ingest error if we ever have multiple loculus accession for one insdc accession in loculus #2844

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44c9f19
Raise error if we ever have multiple loculus accession in ingest
anna-parker Sep 19, 2024
39301d1
update files (to try to re-trigger duplication bug)
anna-parker Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ingest/scripts/call_loculus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,14 +358,13 @@ def get_submitted(config: Config):
"jointAccession": joint_accession,
}
elif loculus_accession != submitted_dict[insdc_accession]["loculus_accession"]:
# For now to be forgiving, just move on, but log the error
# This should not happen in production
message = (
f"INSDC accession {insdc_accession} has multiple loculus accessions: "
f"{loculus_accession} and {submitted_dict[insdc_accession]['loculus_accession']}"
f"{loculus_accession} and "
f"{submitted_dict[insdc_accession]['loculus_accession']}!"
)
logger.error(message)
continue
raise ValueError(message)

submitted_dict[insdc_accession]["versions"].append(
{
Expand Down
Loading