Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy): hotfix mistake in my changes to deploy.py to handle subdomains appropriately #2849

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Sep 19, 2024

I made a mistake in what was meant to be a helpful feature to avoid confusion. It should allow main.loculus.org but not loculus.org but I used <= not < so it currently doesn't allow main.loculus.org. Apologies.

@theosanderson theosanderson enabled auto-merge (squash) September 19, 2024 16:34
@theosanderson theosanderson changed the title fix(deploy): hotfix mistake in my changes to deploy.py fix(deploy): hotfix mistake in my changes to deploy.py to handle subdomains appropriately Sep 19, 2024
Copy link
Member

@emmahodcroft emmahodcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@theosanderson theosanderson merged commit 266b7bf into main Sep 19, 2024
16 checks passed
@theosanderson theosanderson deleted the hotfix-teak branch September 19, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants