Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Edit group info #2854

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

feat: Edit group info #2854

wants to merge 36 commits into from
+783 −320

Commits on Oct 3, 2024

  1. fix: make readme file links relative so they are clickable again

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6f48e0a View commit details
    Browse the repository at this point in the history

  2. feat: add jq test to script; use 'env' instead of 'bash' directly

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6fd03ec View commit details
    Browse the repository at this point in the history

  3. add some documentation to the Kubernetes README

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    18de929 View commit details
    Browse the repository at this point in the history

  4. WIP - adding the backend stuff

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    97c3db0 View commit details
    Browse the repository at this point in the history

  5. move port info higher up in the README

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    545ea5b View commit details
    Browse the repository at this point in the history

  6. Add TODO for test

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    12d5ae4 View commit details
    Browse the repository at this point in the history

  7. Add more TODOs in relevant files so I don't forget where to change stuff

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    7656622 View commit details
    Browse the repository at this point in the history

  8. Add code to update the group

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    7362eac View commit details
    Browse the repository at this point in the history

  9. linter fixes

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0dc21ca View commit details
    Browse the repository at this point in the history

  10. Add docker check to gradle to prevent cryptic test failures due to do… 

    …cker not started
    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6872d7f View commit details
    Browse the repository at this point in the history

  11. Add test

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8c44d79 View commit details
    Browse the repository at this point in the history

  12. Formatting

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e680f92 View commit details
    Browse the repository at this point in the history

  13. Add Edit group button (WIP)

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3bdb175 View commit details
    Browse the repository at this point in the history

  14. Add edit page stub and routing

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    86f2a5b View commit details
    Browse the repository at this point in the history

  15. 1st working version

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8530a68 View commit details
    Browse the repository at this point in the history

  16. a bit of cleanup

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    510feb6 View commit details
    Browse the repository at this point in the history

  17. fixed a todo

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a4df845 View commit details
    Browse the repository at this point in the history

  18. cleanup field mapping stuff

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9e8136c View commit details
    Browse the repository at this point in the history

  19. fix broken test

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2b626a4 View commit details
    Browse the repository at this point in the history

  20. address review

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a4a0bca View commit details
    Browse the repository at this point in the history

  21. Remove todo

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d7554f6 View commit details
    Browse the repository at this point in the history

  22. turn button into anchor tag

    @fhennig @corneliusroemer
    fhennig authored and corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a70c205 View commit details
    Browse the repository at this point in the history

  23. document where group info should be propagated 

    #2939
    @corneliusroemer
    corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    1ced011 View commit details
    Browse the repository at this point in the history

  24. Document limitation in README

    @corneliusroemer
    corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    155eb23 View commit details
    Browse the repository at this point in the history

  25. Clarify that group name is never used in ingest pipeline other than f… 

    …or group creation

Closes #2820
    @corneliusroemer
    corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    fa2842a View commit details
    Browse the repository at this point in the history

  26. Document group info updatability

    @corneliusroemer
    corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8d65082 View commit details
    Browse the repository at this point in the history

  27. Add stub for group info update -> released data integration test

    @corneliusroemer
    corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f34b42f View commit details
    Browse the repository at this point in the history

  28. Add todo for website e2e test

    @corneliusroemer
    corneliusroemer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5d6d5e7 View commit details
    Browse the repository at this point in the history

  29. Automated backend code formatting

    Loculus bot committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c1fce8d View commit details
    Browse the repository at this point in the history

  30. Update backend/src/test/kotlin/org/loculus/backend/controller/groupma… 

    …nagement/GroupManagementControllerTest.kt

Co-authored-by: Cornelius Roemer <[email protected]>
    @fhennig @corneliusroemer
    fhennig and corneliusroemer authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    18c8524 View commit details
    Browse the repository at this point in the history

  31. Add test for 'alternative user can't edit group

    @fhennig
    fhennig committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    cf5d7df View commit details
    Browse the repository at this point in the history

  32. Add test for 'superuser can edit group'

    @fhennig
    fhennig committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    00e5f3a View commit details
    Browse the repository at this point in the history

  33. Refactor testing

    @fhennig
    fhennig committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d409448 View commit details
    Browse the repository at this point in the history

  34. Refactor testing

    @fhennig
    fhennig committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b77c665 View commit details
    Browse the repository at this point in the history

  35. Update loculus docs

    @fhennig
    fhennig committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2d15399 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. test(backend): Test that updated group info ends up in released data (#… 

    …2943)

* Failing test

* Add init that was missing
    @fhennig
    fhennig authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8c65e21 View commit details
    Browse the repository at this point in the history