fix(website): don't display data as "restricted" when the last restricted data use terms expired

[fengelniederhammer]

preview URL: http://fixdatausetermsdisplay.loculus.org

Bug

Website seq details showed restricted even after expiration of restriction.

See https://loculus.slack.com/archives/C05G172HL6L/p1727769592602569

Summary

Root cause was misunderstanding in website code of what the dataUseTermsHistory contains.

The website code assumed there would be a new entry when something becomes open, but in fact the history is just a log of changes.

The backend only returns the history - which does not include "OPEN" as a last entry when the restricted period expired. LAPIS has the correct values - let's simply rely on that.

This assumes the following as correct:

• The backend just stores the history (not the state) of data use terms.
• getting the history from the backend for a sequence entry that has expired restricted use terms will still only show "restricted" entries

We now simply take the use terms from LAPIS, that means the calculation is done in a single place for search and display.

Screenshot

PR Checklist

• All necessary documentation has been adapted.
• The implemented feature is covered by an appropriate test.

[corneliusroemer]

Testing this here:

• Try out website fix pathoplexus/pathoplexus#197
• Update config.json pathoplexus/loculus_deployments#90
  As it's easiest tested on production-like data

[corneliusroemer]

Ok test works! 🎉

I'll add the line to check data use terms are string so as not to produce wrong data.

[corneliusroemer]

Suggested change

	const dataUseTerms = tableData.find((entry) => entry.name === DATA_USE_TERMS_FIELD);
	const dataUseTerms = tableData.find((entry) => entry.name === DATA_USE_TERMS_FIELD);
	// Calculation below is based on the assumption that dataUseTerms is a string
	// Hence assert to get loud error instead of quiet false data
	if (typeof dataUseTerms?.value !== 'string') {
	throw new Error('Code assumes dataUseTerms are of type string. If it isn't, then need to change the calculation of isRestricted.');
	}

[fengelniederhammer]

Sorry - already merged. If you still think it's necessary, you can open a separate PR.