fix(ena-submission): temporarily do not send gcaAccession to Loculus #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-parker
force-pushed
the
temp_fixes
branch
from
4b3dbb0
to
9439818
Compare
anna-parker
changed the title
anna-parker
changed the title
anna-parker
force-pushed
the
temp_fixes
branch
from
9439818
to
a7182e1
Compare
corneliusroemer
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workaround until we figure out #2945
preview URL: https://tempfixes.loculus.org or https://temp-fixes.loculus.org
Summary
The ena-submission pipeline is failing to upload external metadata because it is uploading a gcaAccession field which is currently missing from the config.yaml.
Adding new metadata fields currently causes issues (this might be helped by addressing #2793), until these can be resolved we temporarily do not upload the gcaAccession to Loculus.
This PR also fixes an unrelated little bug in the dry-run script.
Screenshot
PR Checklist