Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): audit log when someone sets data use terms #2959

Merged
merged 1 commit into from
Oct 7, 2024
Merged

feat(backend): audit log when someone sets data use terms #2959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...d/src/main/kotlin/org/loculus/backend/service/datauseterms/DataUseTermsDatabaseService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import org.loculus.backend.api.DataUseTermsHistoryEntry
import org.loculus.backend.api.DataUseTermsType
import org.loculus.backend.auth.AuthenticatedUser
import org.loculus.backend.controller.NotFoundException
import org.loculus.backend.log.AuditLogger
import org.loculus.backend.service.submission.AccessionPreconditionValidator
import org.loculus.backend.utils.Accession
import org.springframework.stereotype.Service
Expand All @@ -20,6 +21,7 @@ import org.springframework.transaction.annotation.Transactional
class DataUseTermsDatabaseService(
private val accessionPreconditionValidator: AccessionPreconditionValidator,
private val dataUseTermsPreconditionValidator: DataUseTermsPreconditionValidator,
private val auditLogger: AuditLogger,
) {

fun setNewDataUseTerms(
Expand Down Expand Up @@ -47,6 +49,11 @@ class DataUseTermsDatabaseService(
}
this[DataUseTermsTable.userNameColumn] = authenticatedUser.username
}

auditLogger.log(
username = authenticatedUser.username,
description = "Set data use terms to $newDataUseTerms for accessions ${accessions.joinToString()}",
)
}

fun getDataUseTermsHistory(accession: Accession): List<DataUseTermsHistoryEntry> {
Expand Down
5 changes: 3 additions & 2 deletions backend/src/main/kotlin/org/loculus/backend/service/submission/UploadDatabaseService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ class UploadDatabaseService(
} ?: emptyList()

if (submissionParams is SubmissionParams.OriginalSubmissionParams) {
log.debug { "Setting data use terms for submission $uploadId to ${submissionParams.dataUseTerms}" }
dataUseTermsDatabaseService.setNewDataUseTerms(
submissionParams.authenticatedUser,
insertionResult.map { it.accession },
Expand All @@ -197,8 +198,8 @@ class UploadDatabaseService(
}

auditLogger.log(
submissionParams.authenticatedUser.username,
"Submitted or revised ${insertionResult.size} sequences: " +
username = submissionParams.authenticatedUser.username,
description = "Submitted or revised ${insertionResult.size} sequences: " +
insertionResult.joinToString { it.displayAccessionVersion() },
)

Expand Down
Loading