Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): return open data use terms url in get-released-data when data is open #2962

Conversation

fengelniederhammer
Copy link
Contributor

@fengelniederhammer fengelniederhammer commented Oct 7, 2024

resolves #2953

preview URL: https://2953-datausetermsurl-does.loculus.org/

Summary

Screenshot

PR Checklist

- [ ] All necessary documentation has been adapted.

  • The implemented feature is covered by an appropriate test.

@fengelniederhammer fengelniederhammer added the preview Triggers a deployment to argocd label Oct 7, 2024
@fengelniederhammer fengelniederhammer changed the title ix(backend): return open data use terms url in get-released-data when data is open fix(backend): return open data use terms url in get-released-data when data is open Oct 7, 2024
corneliusroemer added a commit to pathoplexus/pathoplexus that referenced this pull request Oct 7, 2024
corneliusroemer added a commit to pathoplexus/loculus_deployments that referenced this pull request Oct 7, 2024
corneliusroemer added a commit to pathoplexus/loculus_deployments that referenced this pull request Oct 7, 2024
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks you!

@corneliusroemer corneliusroemer force-pushed the 2953-datausetermsurl-doesnt-change-to-open-when-restricted-sequence-becomes-open branch from e83b6a6 to ccc288f Compare October 7, 2024 13:00
@fengelniederhammer fengelniederhammer merged commit bfc91ec into main Oct 7, 2024
17 checks passed
@fengelniederhammer fengelniederhammer deleted the 2953-datausetermsurl-doesnt-change-to-open-when-restricted-sequence-becomes-open branch October 7, 2024 14:54
@corneliusroemer
Copy link
Contributor

Test on staging works:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dataUseTermsUrl doesn't change to open when restricted sequence becomes open
3 participants