-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): return open data use terms url in get-released-data
when data is open
#2962
Merged
fengelniederhammer
merged 3 commits into
main
from
2953-datausetermsurl-doesnt-change-to-open-when-restricted-sequence-becomes-open
Oct 7, 2024
Merged
fix(backend): return open data use terms url in get-released-data
when data is open
#2962
fengelniederhammer
merged 3 commits into
main
from
2953-datausetermsurl-doesnt-change-to-open-when-restricted-sequence-becomes-open
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengelniederhammer
changed the title
ix(backend): return open data use terms url in
fix(backend): return open data use terms url in Oct 7, 2024
get-released-data
when data is openget-released-data
when data is open
chaoran-chen
reviewed
Oct 7, 2024
...end/src/test/kotlin/org/loculus/backend/controller/submission/GetReleasedDataEndpointTest.kt
Show resolved
Hide resolved
chaoran-chen
reviewed
Oct 7, 2024
chaoran-chen
reviewed
Oct 7, 2024
...rc/main/kotlin/org/loculus/backend/service/seqsetcitations/SeqSetCitationsDatabaseService.kt
Outdated
Show resolved
Hide resolved
corneliusroemer
added a commit
to pathoplexus/pathoplexus
that referenced
this pull request
Oct 7, 2024
corneliusroemer
added a commit
to pathoplexus/loculus_deployments
that referenced
this pull request
Oct 7, 2024
corneliusroemer
added a commit
to pathoplexus/loculus_deployments
that referenced
this pull request
Oct 7, 2024
chaoran-chen
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks you!
…hen data is open resolves #2953
This is probably a bit more efficient
corneliusroemer
force-pushed
the
2953-datausetermsurl-doesnt-change-to-open-when-restricted-sequence-becomes-open
branch
from
October 7, 2024 13:00
e83b6a6
to
ccc288f
Compare
fengelniederhammer
deleted the
2953-datausetermsurl-doesnt-change-to-open-when-restricted-sequence-becomes-open
branch
October 7, 2024 14:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2953
preview URL: https://2953-datausetermsurl-does.loculus.org/
Summary
Screenshot
PR Checklist
- [ ] All necessary documentation has been adapted.