Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ena add address #2965

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Ena add address #2965

merged 5 commits into from
Oct 7, 2024

Conversation

anna-parker
Copy link
Contributor

@anna-parker anna-parker commented Oct 7, 2024

resolves #

preview URL: https://ena-add-address.loculus.org/

Summary

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@anna-parker anna-parker added the preview Triggers a deployment to argocd label Oct 7, 2024
# Conflicts:
#	ena-submission/scripts/create_assembly.py
(cherry picked from commit 673786c)
try:
group_info = get_group_info(config, project_table_entry["group_id"])[0]["group"]
address = group_info["address"]
address_string = (f'{address.get("line1", "")}, {address.get("line2", "")}, '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only use whatever is present, but I can do that later

@corneliusroemer corneliusroemer marked this pull request as ready for review October 7, 2024 16:04
@corneliusroemer corneliusroemer merged commit 6064eda into add_authors_to_manifest Oct 7, 2024
11 checks passed
@corneliusroemer corneliusroemer deleted the ena_add_address branch October 7, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants