Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prepro): Add metadata processing tests #2971

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Conversation

anna-parker
Copy link
Contributor

@anna-parker anna-parker commented Oct 7, 2024

resolves #

preview URL: https://test-prepro-v2.loculus.org/

Summary

This PR:

  • renames process_date to parse_and_assert_past_date to make function clearer
  • adds prepro metadata processing tests to the CI
  • changes function checks from if date is None: to if not date to handle case when input is ""
  • Makes error/warning messages clearer by always adding the output_field
  • Removes outdated tests

It also uses @fengelniederhammer's suggestion for structuring preprocessing tests: #2888 (review).

  • adds factory methods for generating UnprocessedEntry and ProcessedEntry objects
  • Creates a test structure, with UnprocessedEntry as input and ProcessedEntry as expected_output and confirms the output of process_all corresponds to expected_output.

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@anna-parker anna-parker added the preview Triggers a deployment to argocd label Oct 7, 2024
@anna-parker anna-parker changed the title Test prepro v2 feat(prepro): Add metadata processing tests Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant