revisit /submit-processed-data
#333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pathoplexus ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fengelniederhammer
force-pushed
the
306-revisit-endpoint-submit-processed-data
branch
from
00bdaba
to
0dd4e56
Compare
TobiasKampmann
suggested changes
Oct 9, 2023
backend/src/main/kotlin/org/pathoplexus/backend/controller/SubmissionController.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/pathoplexus/backend/service/SequenceValidatorService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/pathoplexus/backend/service/SequenceValidatorService.kt
Show resolved
Hide resolved
backend/src/test/kotlin/org/pathoplexus/backend/controller/SubmitProcessedDataEndpointTest.kt
Outdated
Show resolved
Hide resolved
backend/src/test/kotlin/org/pathoplexus/backend/controller/SubmitProcessedDataEndpointTest.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/pathoplexus/backend/service/DatabaseService.kt
Show resolved
Hide resolved
backend/src/main/kotlin/org/pathoplexus/backend/service/DatabaseService.kt
Show resolved
Hide resolved
backend/src/main/kotlin/org/pathoplexus/backend/service/DatabaseService.kt
Show resolved
Hide resolved
backend/src/main/kotlin/org/pathoplexus/backend/service/DatabaseService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/pathoplexus/backend/service/DatabaseService.kt
Show resolved
Hide resolved
fengelniederhammer
force-pushed
the
306-revisit-endpoint-submit-processed-data
branch
from
f21f944
to
1259431
Compare
backend/src/main/kotlin/org/pathoplexus/backend/service/SequenceValidatorService.kt
Outdated
Show resolved
Hide resolved
backend/src/test/kotlin/org/pathoplexus/backend/controller/SubmissionConvenienceClient.kt
Show resolved
Hide resolved
TobiasKampmann
approved these changes
Oct 9, 2023
* implement proper error handling. Distinguish between technical errors that rollback the transaction and validation errors that should be shown to the submitter to review. * Improve the descriptions and types in Swagger UI * extract a separate test
fengelniederhammer
force-pushed
the
306-revisit-endpoint-submit-processed-data
branch
from
130e018
to
bb28442
Compare
fengelniederhammer
deleted the
306-revisit-endpoint-submit-processed-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #306