-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): add download dialog to search page #847
Conversation
aa72ae1
to
47a22a9
Compare
47a22a9
to
e247f2f
Compare
Really nice – Q: should you have to agree to the terms if you haven't chosen to include restricted sequences? (I haven't had a chance to look at the code yet, so haven't reviewed for now) |
At the moment, yes. Happy to change it to only showing up when restricted data are chosen if you think that's better. |
website/src/components/SearchPage/DownloadDialog/DownloadActiveFilters.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/DownloadDialog.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/OptionBlock.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/OptionBlock.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/OptionBlock.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/OptionBlock.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/generateDownloadUrl.ts
Outdated
Show resolved
Hide resolved
be6f702
to
47a76b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
website/src/components/SearchPage/DownloadDialog/OptionBlock.tsx
Outdated
Show resolved
Hide resolved
47a76b1
to
8b42025
Compare
resolves #757
Preview: https://757-download-panel.preview.k3s.loculus.org/
Screenshots
Future work
PR Checklist
[ ] All necessary documentation has been adapted.