Configure dummy pipeline to emit warnings/errors #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to leave approval in case @fengelniederhammer has any thoughts since he's been the driving force behind this dummy pipeline. |
fengelniederhammer
approved these changes
Feb 12, 2024
kubernetes/loculus/templates/loculus-preprocessing-deployment.yaml
Outdated
Show resolved
Hide resolved
corneliusroemer
force-pushed
the
dummy-warn-error
branch
from
39b4af3
to
ca9c762
Compare
corneliusroemer
added
preprocessing
corneliusroemer
force-pushed
the
dummy-warn-error
branch
2 times, most recently
from
6beff4a
to
a116223
Compare
|
@fengelniederhammer I've addressed your feedback - the errors/warnings are now deterministic (always on) by default but can be made random with a |
corneliusroemer
commented
Feb 12, 2024
kubernetes/loculus/templates/loculus-preprocessing-deployment.yaml
Outdated
Show resolved
Hide resolved
Refactor deployment template to remove server env check
corneliusroemer
force-pushed
the
dummy-warn-error
branch
from
f44dfdd
to
1641394
Compare
fengelniederhammer
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures the dummy preprocessing pipeline to emit errors and warnings when deployed on the server.
E2E is not touched to simplify testing. But the ability to have submissions with errors/warnings is essential to demonstrate/test how our frontend handles them.
For example, I noticed that the new submission review page shows the "release" paperplane icon even for sequences with errors. This wasn't easy to test before the code changes here.
I also add a
--dry-runfeature to./deploy.pyto make it easiert to see what commands it executes. This helped me understand the precise configuration used by E2E testing.Preview: https://dummy-warn-error.loculus.org
Resolves #983
Screenshots showing that errors now occur: