Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: some low hanging drive-by improvements #993

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

fengelniederhammer
Copy link
Contributor

Leftovers from #842

resolves #991

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • [ ] The implemented feature is covered by an appropriate test.

@fengelniederhammer fengelniederhammer added the refactoring Code requires refactoring label Feb 12, 2024
@fengelniederhammer fengelniederhammer force-pushed the driveByDatasetCitationImprovements branch 3 times, most recently from 10c8ae0 to 252bfa9 Compare February 12, 2024 10:06
Copy link
Contributor

@TobiasKampmann TobiasKampmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor nitpicks

website/src/pages/datasets/index.astro Show resolved Hide resolved
website/src/routes.ts Outdated Show resolved Hide resolved
website/src/utils/parseAccessionInput.ts Outdated Show resolved Hide resolved
website/src/utils/parseAccessionInput.ts Show resolved Hide resolved
@fengelniederhammer fengelniederhammer merged commit 87591b1 into main Feb 12, 2024
12 checks passed
@fengelniederhammer fengelniederhammer deleted the driveByDatasetCitationImprovements branch February 12, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code requires refactoring
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

type function in datasets frontmatter
2 participants