-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix context window for action metadata.name #452
Conversation
✅ Deploy Preview for vcluster-docs-site ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a way to differentiate between repositories, because it's possible that a PR number can be the same in different repositories:
how about something like:
NAME: pr-${{ github.event.pull_request.number }}-${{ github.event.repository.name }}
|
Maybe |
That can be done as well! I checked, and it works for most repos. The only question is, when we look from left to right, should repo come first or PR number? For me having a repo at first makes a bit more sense but I would love to know what you think
|
Repo coming first looks a bit better. Can you update the actions? |
Feel free to take a look! Updated |
Content Description
Currently the context is too long and it creates something that breaks the action. Having just the pr is good enough for demo and to work smoothly so this PR fixes that by removing the not required context. Eg: https://github.com/hrittikhere/vcluster-ghaction/actions/runs/13263668222/job/37025746913
Preview Link
Internal Reference
Closes DOC-