Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix context window for action metadata.name #452

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

hrittikhere
Copy link
Member

@hrittikhere hrittikhere commented Feb 11, 2025

Content Description

Currently the context is too long and it creates something that breaks the action. Having just the pr is good enough for demo and to work smoothly so this PR fixes that by removing the not required context. Eg: https://github.com/hrittikhere/vcluster-ghaction/actions/runs/13263668222/job/37025746913

image

Preview Link

Internal Reference

Closes DOC-

Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for vcluster-docs-site ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 045f1ce
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs-site/deploys/67b48621e6d2ef000872c9a6
😎 Deploy Preview https://deploy-preview-452--vcluster-docs-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Piotr1215 Piotr1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a way to differentiate between repositories, because it's possible that a PR number can be the same in different repositories:

how about something like:

NAME: pr-${{ github.event.pull_request.number }}-${{ github.event.repository.name }}

@hrittikhere
Copy link
Member Author

${{ github.event.repository.name }}- pr-${{ github.event.pull_request.number }} should be better right?

@Piotr1215
Copy link
Contributor

Maybe pr-${{ github.event.pull_request.number }}-repo-${{ github.event.repository.name }} if it's not too long?

@hrittikhere
Copy link
Member Author

That can be done as well! I checked, and it works for most repos. The only question is, when we look from left to right, should repo come first or PR number? For me having a repo at first makes a bit more sense but I would love to know what you think

Table 1 Table 2
repo-test-vcluster-pr-1 pr-1-repo-test-vcluster
repo-test-vcluster-pr-2 pr-2-repo-test-vcluster
repo-test-vcluster-pr-3 pr-3-repo-test-vcluster
repo-test-vcluster-pr-4 pr-4-repo-test-vcluster
repo-test-vcluster-pr-5 pr-5-repo-test-vcluster
repo-test-vcluster-pr-6 pr-6-repo-test-vcluster
repo-test-vcluster-pr-7 pr-7-repo-test-vcluster
repo-test-vcluster-pr-8 pr-8-repo-test-vcluster
repo-test-vcluster-pr-9 pr-9-repo-test-vcluster
repo-test-vcluster-pr-10 pr-10-repo-test-vcluster

@Piotr1215
Copy link
Contributor

Repo coming first looks a bit better. Can you update the actions?

@hrittikhere
Copy link
Member Author

Feel free to take a look! Updated

@Piotr1215 Piotr1215 merged commit ef0e577 into loft-sh:main Feb 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants