Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix context window for action metadata.name #452

Merged
merged 2 commits into from
Feb 19, 2025
Merged

fix context window for action metadata.name #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e43b3c
fix context window for action metadata.name
hrittikhere Feb 11, 2025
045f1ce
update to repo-pr view
hrittikhere Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vcluster/_partials/integrations/github-actions-pull-request-devspace.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
run: vcluster login $LOFT_URL --access-key $ACCESS_KEY
- name: Create PR Virtual Cluster
env:
NAME: pr-${{ github.event.pull_request.number }}-${{ github.sha }}-${{ github.run_id }}
NAME: repo-${{ github.event.repository.name }}-pr-${{ github.event.pull_request.number }}
run: vcluster create $NAME --project default
- name: Run Tests
run: devspace run e2e
Expand Down
2 changes: 1 addition & 1 deletion ...ster/_partials/integrations/github-actions-vclusters-pull-request-automatic.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Create Virtual Cluster for PR
uses: loft-sh/create-vcluster@main
with:
name: pr-${{ github.event.pull_request.number }}-${{ github.sha }}-${{ github.run_id }}
name: repo-${{ github.event.repository.name }}-pr-${{ github.event.pull_request.number }}
auto-cleanup: true
- name: Deploy Application
run: kubectl apply -Rf ./kubernetes
Expand Down
4 changes: 2 additions & 2 deletions vcluster/_partials/integrations/github-actions-vclusters-pull-request-manual.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run: vcluster login $LOFT_URL --access-key $ACCESS_KEY
- name: Create PR Virtual Cluster
env:
NAME: pr-${{ github.event.pull_request.number }}-${{ github.sha }}-${{ github.run_id }}
NAME: repo-${{ github.event.repository.name }}-pr-${{ github.event.pull_request.number }}
run: vcluster create $NAME --project default
- name: Deploy Application
run: kubectl apply -Rf ./kubernetes
Expand All @@ -30,7 +30,7 @@ jobs:
run: make e2e
- name: Delete PR Virtual Cluster
env:
NAME: pr-${{ github.event.pull_request.number }}-${{ github.sha }}-${{ github.run_id }}
NAME: repo-${{ github.event.repository.name }}-pr-${{ github.event.pull_request.number }}
run: vcluster delete $NAME --project default
```

Expand Down
2 changes: 1 addition & 1 deletion vcluster/_partials/integrations/github-actions-vclusters-pull-request-use.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run: vcluster login $LOFT_URL --access-key $ACCESS_KEY
- name: Create PR Virtual Cluster
env:
NAME: pr-${{ github.event.pull_request.number }}-${{ github.sha }}-${{ github.run_id }}
NAME: repo-${{ github.event.repository.name }}-pr-${{ github.event.pull_request.number }}
run: vcluster create $NAME --project default --upgrade
- name: Deploy Application
run: kubectl apply -Rf ./kubernetes
Expand Down