Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOUD-700] Add support for GCP #294

Merged
merged 13 commits into from
Jan 30, 2024

fixes for review

75794ac
Select commit
Loading
Failed to load commit list.
Merged

[CLOUD-700] Add support for GCP #294

fixes for review
75794ac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2024 in 0s

91.87% (+0.43%) compared to 1a522b4

View this Pull Request on Codecov

91.87% (+0.43%) compared to 1a522b4

Details

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1a522b4) 91.43% compared to head (75794ac) 91.87%.
Report is 1 commits behind head on main.

Files Patch % Lines
...rce_gcp_service_account_custom_role_permissions.go 95.31% 2 Missing and 1 partial ⚠️
hopsworksai/resource_cluster_from_backup.go 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   91.43%   91.87%   +0.43%     
==========================================
  Files          23       24       +1     
  Lines        3479     3741     +262     
==========================================
+ Hits         3181     3437     +256     
- Misses        219      224       +5     
- Partials       79       80       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.