Update GH actions for master and prs #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacv
force-pushed
the
gh/actions-for-pr
branch
from
a099909
to
b1b342b
Compare
Comment on lines
+14
to
+17
| strategy: | ||
| fail-fast: true | ||
| matrix: | ||
| feature: [libp2p, waku] |
There was a problem hiding this comment.
It seems the fail-fast: true doesn't work because we have the continue-on-error: true for the cargo check step below, probably?
For example, the cargo check failed in the PR: https://github.com/logos-co/nomos-node/actions/runs/6046982217/job/16409567703?pr=316, but it show me the green light.
There was a problem hiding this comment.
fail-fast: true is set for master branch. PRs has a separate file prs.yml and it's set to fail-fast: false. But I'll update the cargo check step to continue-on-error: false
There was a problem hiding this comment.
Ah, i left this comment at the wrong position :)) but it seems the pr.yml also has the same settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated and re added github actions for PRs.