-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GH actions for master and prs #365
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| # copy of https://github.com/actions-rs/meta/blob/master/recipes/quickstart.md | ||
| # Steps for checking PRs. | ||
| on: | ||
| pull_request: | ||
| branches: | ||
| - "*" | ||
|
|
||
| name: PR check | ||
|
|
||
| jobs: | ||
| check: | ||
| name: Check | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: true | ||
| matrix: | ||
| feature: [libp2p, waku] | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| with: | ||
| submodules: true | ||
| - uses: actions-rs/toolchain@v1 | ||
| with: | ||
| profile: minimal | ||
| toolchain: stable | ||
| override: true | ||
| - uses: actions-rs/cargo@v1 | ||
| continue-on-error: true | ||
| with: | ||
| command: check | ||
| args: --all --no-default-features --features ${{ matrix.feature }} | ||
|
|
||
| test: | ||
| name: Test Suite | ||
| if: ${{ !startsWith(github.event.pull_request.title, '[WIP]') && !contains(github.event.label.name, 'DO NOT MERGE') }} | ||
| strategy: | ||
| fail-fast: false # all OSes should be tested even if one fails (default: true) | ||
| matrix: | ||
| feature: [libp2p, waku] | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| with: | ||
| submodules: true | ||
| - uses: actions/setup-go@v3 # we need go to build go-waku | ||
| with: | ||
| go-version: '1.19' | ||
| - uses: actions-rs/toolchain@v1 | ||
| with: | ||
| profile: minimal | ||
| toolchain: stable | ||
| override: true | ||
| - uses: actions-rs/cargo@v1 | ||
| continue-on-error: true | ||
| with: | ||
| command: build | ||
| args: --all --no-default-features --features ${{ matrix.feature }} | ||
| - uses: actions-rs/cargo@v1 | ||
| continue-on-error: true | ||
| with: | ||
| command: test | ||
| args: --all --no-default-features --features ${{ matrix.feature }} | ||
|
|
||
| lints: | ||
| name: Rust lints | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| feature: [libp2p, waku] | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| with: | ||
| submodules: true | ||
| - uses: actions-rs/toolchain@v1 | ||
| with: | ||
| profile: minimal | ||
| toolchain: stable | ||
| override: true | ||
| components: rustfmt, clippy | ||
|
|
||
| - name: Run cargo fmt | ||
| uses: actions-rs/cargo@v1 | ||
| continue-on-error: true | ||
| with: | ||
| command: fmt | ||
| args: --all -- --check | ||
|
|
||
| - name: Run cargo clippy | ||
| uses: actions-rs/cargo@v1 | ||
| continue-on-error: true | ||
| with: | ||
| command: clippy | ||
| args: --all --no-default-features --features ${{ matrix.feature }} -- --deny warnings |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the
fail-fast: truedoesn't work because we have thecontinue-on-error: truefor thecargo checkstep below, probably?For example, the
cargo checkfailed in the PR: https://github.com/logos-co/nomos-node/actions/runs/6046982217/job/16409567703?pr=316, but it show me the green light.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fail-fast: trueis set for master branch. PRs has a separate fileprs.ymland it's set tofail-fast: false. But I'll update the cargo check step tocontinue-on-error: falseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, i left this comment at the wrong position :)) but it seems the
pr.ymlalso has the same settings.