-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add detailed timeout options #81
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 73.21% 74.36% +1.15%
==========================================
Files 17 18 +1
Lines 896 987 +91
==========================================
+ Hits 656 734 +78
- Misses 139 145 +6
- Partials 101 108 +7 ☔ View full report in Codecov by Sentry. |
Diffs from merge are confirmed. index 1234ab8..48b7e12 100644
--- a/cage.go
+++ b/cage.go
@@ -43,7 +43,7 @@ func NewCage(input *Input) Cage {
return &cage{
Input: input,
Timeout: timeout.NewManager(
- 10*time.Minute,
+ 15*time.Minute,
&timeout.Input{
TaskRunningWait: taskRunningWait,
TaskHealthCheckWait: taskHealthCheckWait, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check after #84 is merged into main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few comments, but overall it looks good.
.vscode/settings.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[NITS] [IMO] We might not need to include .vscode/settings.json
in the git repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. We need to include settings. Sharing settings is quite common way in modern JS development, as there're essential settings in addition to for each personal environment. Those should be considered, but useful in most case.
https://github.com/vitest-dev/vitest/tree/main/.vscode
https://github.com/jestjs/jest/tree/main/.vscode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -306,10 +310,36 @@ func (c *CanaryTask) waitUntilTargetHealthy( | |||
} | |||
} | |||
|
|||
func (c *CanaryTask) targetDeregistrationDelay(ctx context.Context) (time.Duration, error) { | |||
deregistrationDelay := 300 * time.Second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deregistration_delay.timeout_seconds
The amount of time for Elastic Load Balancing to wait before deregistering a target. The range is 0–3600 seconds. The default value is 300 seconds.
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-target-groups.html
Nice 👍
@takkyuuplayer @alfnets A comment out was omitted. Could we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
rollout
cmd to usederegistration_delay.timeout_seconds
by fetching from ALB target group's attributes if exists (Default: 300s).rollout
cmd not to stop to stoup canary task even if any error occurs during deregistering canary task from target group.