Reapply "feat: support canary test for multiple load balancers (#80)"… #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 73.93% 73.21% -0.72%
==========================================
Files 16 17 +1
Lines 890 896 +6
==========================================
- Hits 658 656 -2
- Misses 134 139 +5
- Partials 98 101 +3 ☔ View full report in Codecov by Sentry. |
|
@takkyuuplayer Sorry for assigning to review serially. This is exceeded changes for #81 that is temporally reverted in main, including titled feature and refactoring around |
canary_task.go
Outdated
Comment on lines
101
to
115
| wait := make(chan bool) | ||
| go func() { | ||
| duration := c.Env.CanaryTaskIdleDuration | ||
| for duration > 0 { | ||
| log.Infof("still waiting...; %d seconds left", duration) | ||
| wt := 10 | ||
| if duration < 10 { | ||
| wt = duration | ||
| } | ||
| <-c.Time.NewTimer(time.Duration(wt) * time.Second).C | ||
| duration -= 10 | ||
| } | ||
| wait <- true | ||
| }() | ||
| <-wait |
There was a problem hiding this comment.
Unnecessary goroutine. The below seems enough.
duration := c.Env.CanaryTaskIdleDuration
for duration > 0 {
log.Infof("still waiting...; %d seconds left", duration)
wt := 10
if duration < 10 {
wt = duration
}
<-c.Time.NewTimer(time.Duration(wt) * time.Second).C
duration -= 10
}There was a problem hiding this comment.
I agree and ctx.Done() should also be evaluated with select.
canary_task.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (c *CanaryTask) waitUntilHealthCeheckPassed(ctx context.Context) error { |
There was a problem hiding this comment.
typo
Suggested change
| func (c *CanaryTask) waitUntilHealthCeheckPassed(ctx context.Context) error { | |
| func (c *CanaryTask) waitUntilHealthCheckPassed(ctx context.Context) error { |
There was a problem hiding this comment.
typo still exists
Ceheck --> Check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#83)
This reverts commit d43c8c5.