Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply "feat: support canary test for multiple load balancers (#80)"… #84
Reapply "feat: support canary test for multiple load balancers (#80)"… #84
Changes from 1 commit
90c6777
882add9
ba0f5c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 47 in canary_task.go
Codecov / codecov/patch
canary_task.go#L47
Check warning on line 61 in canary_task.go
Codecov / codecov/patch
canary_task.go#L61
Check warning on line 75 in canary_task.go
Codecov / codecov/patch
canary_task.go#L75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary goroutine. The below seems enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree and
ctx.Done()
should also be evaluated withselect
.Check warning on line 121 in canary_task.go
Codecov / codecov/patch
canary_task.go#L121
Check warning on line 125 in canary_task.go
Codecov / codecov/patch
canary_task.go#L125
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo still exists
Ceheck --> Check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've cehecked!
Check warning on line 145 in canary_task.go
Codecov / codecov/patch
canary_task.go#L145
Check warning on line 149 in canary_task.go
Codecov / codecov/patch
canary_task.go#L149
Check warning on line 177 in canary_task.go
Codecov / codecov/patch
canary_task.go#L177
Check warning on line 204 in canary_task.go
Codecov / codecov/patch
canary_task.go#L204
Check warning on line 209 in canary_task.go
Codecov / codecov/patch
canary_task.go#L209
Check warning on line 221 in canary_task.go
Codecov / codecov/patch
canary_task.go#L221
Check warning on line 228 in canary_task.go
Codecov / codecov/patch
canary_task.go#L228
Check warning on line 232 in canary_task.go
Codecov / codecov/patch
canary_task.go#L232
Check warning on line 247 in canary_task.go
Codecov / codecov/patch
canary_task.go#L247
Check warning on line 275 in canary_task.go
Codecov / codecov/patch
canary_task.go#L275
Check warning on line 292 in canary_task.go
Codecov / codecov/patch
canary_task.go#L289-L292
Check warning on line 298 in canary_task.go
Codecov / codecov/patch
canary_task.go#L298
Check warning on line 306 in canary_task.go
Codecov / codecov/patch
canary_task.go#L302-L306
Check warning on line 323 in canary_task.go
Codecov / codecov/patch
canary_task.go#L323
Check warning on line 333 in canary_task.go
Codecov / codecov/patch
canary_task.go#L333
Check warning on line 345 in canary_task.go
Codecov / codecov/patch
canary_task.go#L345
Check warning on line 351 in canary_task.go
Codecov / codecov/patch
canary_task.go#L351