Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-45863: Resolve BPS parsl AttributeError for attr 'keys' #34

Merged
merged 1 commit into from
Aug 20, 2024
Merged

DM-45863: Resolve BPS parsl AttributeError for attr 'keys' #34

merged 1 commit into from
Aug 20, 2024

Conversation

leeskelvin
Copy link
Contributor

@leeskelvin leeskelvin commented Aug 20, 2024 •
edited
Loading

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.21%. Comparing base (1fdf821) to head (dfb96b5).
Report is 2 commits behind head on main.

Files Patch % Lines
python/lsst/ctrl/bps/parsl/job.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   47.21%   47.21%           
=======================================
  Files          11       11           
  Lines         377      377           
  Branches       61       61           
=======================================
  Hits          178      178           
  Misses        190      190           
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MichelleGower
MichelleGower approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merge approved.

@leeskelvin leeskelvin merged commit bacbdd1 into main Aug 20, 2024
16 of 17 checks passed
@leeskelvin leeskelvin deleted the tickets/DM-45863 branch August 20, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelleGower MichelleGower MichelleGower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leeskelvin @MichelleGower