Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-45863: Resolve BPS parsl AttributeError for attr 'keys' #34

Merged
merged 1 commit into from
Aug 20, 2024
Merged

DM-45863: Resolve BPS parsl AttributeError for attr 'keys' #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/changes/DM-45863.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Resolved issue relating to the high throughput executor performing validation via checking of a resource spec dictionary.
Until now, ctrl_bps_parsl was passing None instead of an empty dict when there are no resource requests associated with a task.

2 changes: 1 addition & 1 deletion python/lsst/ctrl/bps/parsl/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@
command = self.evaluate_command_line(command)
if command_prefix:
command = command_prefix + "\n" + command
resources = self.get_resources() if add_resources else None
resources = self.get_resources() if add_resources else {}

Check warning on line 285 in python/lsst/ctrl/bps/parsl/job.py

View check run for this annotation

Codecov / codecov/patch

python/lsst/ctrl/bps/parsl/job.py#L285 

Added line #L285 was not covered by tests

# Add a layer of indirection to which we can add a useful name.
# This name is used by parsl for tracking workflow status.
Expand Down
Loading