DM-42004: Update the module name for FitsMaskedImage formatter #917
Conversation
| @@ -40,7 +40,7 @@ ImageU: lsst.obs.base.formatters.fitsExposure.FitsImageFormatter | |||
| DecoratedImageU: lsst.obs.base.formatters.fitsExposure.FitsExposureFormatter | |||
| Mask: lsst.obs.base.formatters.fitsExposure.FitsMaskFormatter | |||
| MaskX: lsst.obs.base.formatters.fitsExposure.FitsMaskFormatter | |||
| MaskedImageF: lsst.obs.base.formatters.fitsMaskedImage.FitsMaskedImageFormatter | |||
| MaskedImageF: lsst.obs.base.formatters.fitsExposure.FitsMaskedImageFormatter | |||
There was a problem hiding this comment.
If you're moving this, the original needs to continue to work (basically forever) since this string is written into the butler database for datasets we've already written. That makes me wonder if it's actually worthwhile to move it.
There was a problem hiding this comment.
I'm not moving any code. I don't think this was ever correct, since the formatter had been defined in fitsExposure.py.
https://github.com/lsst/obs_base/blob/main/python/lsst/obs/base/formatters/fitsExposure.py#L26
There was a problem hiding this comment.
I'm pretty sure this is fixing a typo.
There was a problem hiding this comment.
Yup. I should perhaps update the PR title/ticket title?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #917 +/- ##
========================================
Coverage 87.31% 87.31%
========================================
Files 286 286
Lines 37168 37168
Branches 7318 7833 +515
========================================
Hits 32452 32452
Misses 3519 3519
Partials 1197 1197 ☔ View full report in Codecov by Sentry. |
arunkannawadi
changed the title
arunkannawadi
changed the title
Checklist
doc/changes