Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42004: Update the module name for FitsMaskedImage formatter #917

Merged
merged 1 commit into from
Dec 5, 2023
Merged

DM-42004: Update the module name for FitsMaskedImage formatter #917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/lsst/daf/butler/configs/datastores/formatters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ ImageU: lsst.obs.base.formatters.fitsExposure.FitsImageFormatter
DecoratedImageU: lsst.obs.base.formatters.fitsExposure.FitsExposureFormatter
Mask: lsst.obs.base.formatters.fitsExposure.FitsMaskFormatter
MaskX: lsst.obs.base.formatters.fitsExposure.FitsMaskFormatter
MaskedImageF: lsst.obs.base.formatters.fitsMaskedImage.FitsMaskedImageFormatter
MaskedImageF: lsst.obs.base.formatters.fitsExposure.FitsMaskedImageFormatter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're moving this, the original needs to continue to work (basically forever) since this string is written into the butler database for datasets we've already written. That makes me wonder if it's actually worthwhile to move it.

Copy link
Member Author

@arunkannawadi arunkannawadi Dec 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not moving any code. I don't think this was ever correct, since the formatter had been defined in fitsExposure.py.

https://github.com/lsst/obs_base/blob/main/python/lsst/obs/base/formatters/fitsExposure.py#L26

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this is fixing a typo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. I should perhaps update the PR title/ticket title?

Exposure: lsst.obs.base.formatters.fitsExposure.FitsExposureFormatter
ExposureF: lsst.obs.base.formatters.fitsExposure.FitsExposureFormatter
ExposureI: lsst.obs.base.formatters.fitsExposure.FitsExposureFormatter
Expand Down
Loading