Mic remake #59
Merged
Mic remake #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serafadam
requested changes
Jan 2, 2024
Serafadam
reviewed
Jan 3, 2024
|
I went through all changes mentioned here - unless I missed something. You can merge it if you think it is ok now. |
|
@danilo-pejovic docker build seem to file as not all dependencies are found with rosdep |
|
I didnt push my latest commit last friday. Try it now. Image ghcr.io/luxonis/rae-testing:mic_node_merge_candidate contains merge candidate and is working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rae_msgs:
rae_hw:
Updating LED control
Adding sound recording to wav files