Sequential Bringup #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Serafadam
commented
Feb 7, 2024
•
Serafadam
commented
- Update Mocks and regular nodes to Lifecycle
- Add a simple lifecycle manager to indicate hardware bringup process
- Move peripherals to control launch file for simplicity
- Add wait for ready signal to SDK
- Update Readme to point to docs
rae_hw/src/peripherals/speakers.cpp
Outdated
| @@ -83,8 +104,8 @@ int main(int argc, char* argv[]) { | |||
| rclcpp::init(argc, argv); | |||
|
|
|||
| auto node = std::make_shared<rae_hw::SpeakersNode>(rclcpp::NodeOptions()); | |||
| rclcpp::executors::StaticSingleThreadedExecutor executor; | |||
| executor.add_node(node); | |||
| rclcpp::executors::SingleThreadedExecutor executor; | |||
There was a problem hiding this comment.
Any reason why a dynamic single threaded executor used instead of static one?
There was a problem hiding this comment.
Updated to static
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.