Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing diff controller tests #69

Closed
wants to merge 1 commit into from
Closed

Fixing diff controller tests #69

wants to merge 1 commit into from

Conversation

danilo-pejovic
Copy link
Collaborator

Fixing an bug where diff controller test would start before diff controller is configured and activated, leading to possible silent crash

Serafadam
Serafadam requested changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@Serafadam Serafadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be simpler if we checked state transition of diff_controller in lifecycle_manager using different service call (GetState)

@danilo-pejovic
Copy link
Collaborator Author

Makes sense, I will edit lifecycle manager and make another small pull request

@danilo-pejovic danilo-pejovic deleted the diff_controller_test branch February 13, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serafadam Serafadam Serafadam requested changes

@AnielAlexa AnielAlexa Awaiting requested review from AnielAlexa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danilo-pejovic @Serafadam