Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metainfo data for appstream #1897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

stefonarch
Copy link
Member

Feature list to complete and reorder @tsujan

@tsujan
Copy link
Member

tsujan commented May 21, 2024

I'm not good at this. If you're sure that this is the correct way of adding it, please ship it.

However, there are instances of <li></li>. Are they left empty intentionally?

@stefonarch
Copy link
Member Author

However, there are instances of

  • . Are they left empty intentionally?

    Yes, see first comment.

    @tsujan
    Copy link
    Member

    tsujan commented May 21, 2024

    Oh, it's hard to pick up the most important features; there are many.

    <url type="homepage">https://github.com/lxqt/pcmanfm-qt/</url>
    <screenshots>
    <screenshot type="default">
    <image>https://github.com/lxqt/qps/blob/master/pcmanfm-qt.png</image>
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    <image>https://github.com/lxqt/qps/blob/master/pcmanfm-qt.png</image>
    <image>https://github.com/lxqt/pcmanfm-qt/blob/master/pcmanfm-qt.png</image>

    <li>Full wayland compatible</li>
    <li>Display options per folder</li>
    <li>Connect to server</li>
    <li>Admin mode fot tabs</li>
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    <li>Admin mode fot tabs</li>
    <li>Admin mode for tabs</li>

    <ul>
    <li>Split view</li>
    <li>Filter items by typing</li>
    <li>Full wayland compatible</li>
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    <li>Full wayland compatible</li>
    <li>Fully wayland compatible</li>

    or

    Suggested change
    <li>Full wayland compatible</li>
    <li>Full wayland compatibility</li>

    <li>Split view</li>
    <li>Filter items by typing</li>
    <li>Full wayland compatible</li>
    <li>Display options per folder</li>
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    <li>Display options per folder</li>
    <li>Customize view options per folder</li>

    its features are:
    </p>
    <ul>
    <li>Split view</li>
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    <li>Split view</li>
    <li>Dual-pane (commander) mode</li>

    <li>Display options per folder</li>
    <li>Connect to server</li>
    <li>Admin mode fot tabs</li>
    <li></li>
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    <li></li>
    <li>Four view modes</li>

    (...which I might move up before the "Customize..." entry)

    <li>Connect to server</li>
    <li>Admin mode fot tabs</li>
    <li></li>
    <li></li>
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    <li></li>
    <li>Optional desktop icon support</li>

    @ferdnyc
    Copy link

    ferdnyc commented Nov 10, 2024

    Ideally the appstream metadata would also contain a package release history in a <releases> tag, which can be as simple as:

    <releases>
     <release version="2.0" date="2024-01-01" />
     <release version="1.0" date="2023-01-01" />
    </releases>

    ...Part of the process for releasing new versions of the package would be to insert a new <release> tag at the front of that list.

    Alternatively, a separate XML file can contain the (presumably auto-generated) release info, referenced from the main file with:

    <releases type="external"
     url="https://github.com/lxqt/pcmanfm-qt/blob/master/io.github.lxqt.pcmanfm-qt.releases.xml" />

    (It's required that at least a minimal external release file also be installed locally to ${CMAKE_INSTALL_DATADIR}/metainfo/releases/ as io.github.lxqt.pcmanfm-qt.releases.xml, when using type="external" with or without a url=.)

    <li></li>
    </ul>
    </description>
    <launchable type="desktop-id">pcmanfm-qt.desktop</launchable>
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Not strictly required because <anything>.desktop is still supported as a legacy value, but when converting component IDs to reverse-DNS format, they suggest:

    You may also consider to update the name of the accompanying .desktop file to follow the latest version of the Desktop-Entry specification and use a rDNS name for it as well. In any case, do not forget to mention the new desktop-entry in a <launchable/> tag for this component to keep the application launchable from software centers and the .desktop file data associated with the metainfo data.

    So the .desktop file could ideally be renamed to io.github.lxqt.pcmanfm-qt.desktop, to follow the latest FreeDesktop Desktop-Entry spec (and also be more in line with appstream).

    @tsujan
    Copy link
    Member

    tsujan commented Nov 10, 2024

    @ferdnyc
    Thanks a lot for the info!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants