Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added metainfo data for appstream #1897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added metainfo data for appstream #1897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ install(
FILES icons/pcmanfm-qt.svg
DESTINATION "${CMAKE_INSTALL_PREFIX}/share/icons/hicolor/scalable/apps"
)
# install appstream data
install(FILES pcmanfm-qt.appdata.xml
DESTINATION "${CMAKE_INSTALL_DATADIR}/metainfo")

add_subdirectory(autostart)
add_subdirectory(config)
32 changes: 32 additions & 0 deletions pcmanfm-qt.appdata.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?xml version="1.0" encoding="UTF-8"?>
<component type="desktop-application">
<id>io.github.lxqt.pcmanfm-qt</id>
<metadata_license>CC-BY-4.0</metadata_license>
<project_license>GPLv2</project_license>
<name>PCManFM-Qt</name>
<summary>Filemanager</summary>
<description>
<p>
Fast filemanager and desktop manager written in Qt. Among
its features are:
</p>
<ul>
<li>Split view</li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Split view</li>
<li>Dual-pane (commander) mode</li>

<li>Filter items by typing</li>
<li>Full wayland compatible</li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Full wayland compatible</li>
<li>Fully wayland compatible</li>

or

Suggested change
<li>Full wayland compatible</li>
<li>Full wayland compatibility</li>

<li>Display options per folder</li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Display options per folder</li>
<li>Customize view options per folder</li>

<li>Connect to server</li>
<li>Admin mode fot tabs</li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Admin mode fot tabs</li>
<li>Admin mode for tabs</li>

<li></li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li></li>
<li>Four view modes</li>

(...which I might move up before the "Customize..." entry)

<li></li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li></li>
<li>Optional desktop icon support</li>

<li></li>
</ul>
</description>
<launchable type="desktop-id">pcmanfm-qt.desktop</launchable>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly required because <anything>.desktop is still supported as a legacy value, but when converting component IDs to reverse-DNS format, they suggest:

You may also consider to update the name of the accompanying .desktop file to follow the latest version of the Desktop-Entry specification and use a rDNS name for it as well. In any case, do not forget to mention the new desktop-entry in a <launchable/> tag for this component to keep the application launchable from software centers and the .desktop file data associated with the metainfo data.

So the .desktop file could ideally be renamed to io.github.lxqt.pcmanfm-qt.desktop, to follow the latest FreeDesktop Desktop-Entry spec (and also be more in line with appstream).

<url type="homepage">https://github.com/lxqt/pcmanfm-qt/</url>
<screenshots>
<screenshot type="default">
<image>https://github.com/lxqt/qps/blob/master/pcmanfm-qt.png</image>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<image>https://github.com/lxqt/qps/blob/master/pcmanfm-qt.png</image>
<image>https://github.com/lxqt/pcmanfm-qt/blob/master/pcmanfm-qt.png</image>

</screenshot>
</screenshots>
</component>
Binary file added pcmanfm-qt.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.