Remove Float64 restriction #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throughout the package types are often hard-wired to be Float64. The PR lifts this restriction in some places to allow for any real type. In particular, tihs allows the use of Float32 or Float16 to reduce memory footprint. Structures like `QuadLoss` etc. still require modification in order to not cause conversions to Float64 when computations are made using its fields, but this PR at least allows the user to have data in other formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throughout the package types are often hardwired to be Float64. The PR lifts this restriction in some places to allow for any real type. In particular, this allows the use of Float32 or Float16 in the
Amatrix to reduce memory footprint. Structures likeQuadLossetc. still require modification in order to not cause conversions to Float64 when computations are made using its fields, but this PR at least allows the user to have data in other formats.