-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): add compatibility to php80 #2
base: master
Are you sure you want to change the base?
feat(deps): add compatibility to php80 #2
Conversation
composer.json
Outdated
@@ -14,8 +14,8 @@ | |||
} | |||
], | |||
"require": { | |||
"php": "^7.0", | |||
"phpspec/phpspec": "6.*" | |||
"php": "^7.0 | ^8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JellyBellyDev
Would you mind to set the lower php version to 7.3
and update travis.yml
file accordingly?
Moreover we should test all the things with --PREFER-LOWEST
also; would you mind to add it to building matrix too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonCallisto done, but i don't see travis pipeline... could you tell me why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umh, my bad, maybe we didn't setted it up ever.
I will create the travis ci, in order to check if everything's ok, in the upcoming days.
Let's keep in touch. For the moment, thanks for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've enabled travis for this. Could you please try to trigger the build (maybe by slightly change the commit message?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done! ;)
4081e73
to
aa6fcea
Compare
We must follow this PR carefully! ;) |
… fork to php8 compatibility
e2e5161
to
a5b798f
Compare
a90a7f6
to
262f0e9
Compare
I added also github actions: https://github.com/JellyBellyDev/phpspec-data-provider-extension/actions/runs/463095408 |
@JellyBellyDev I'm following this discussion. I'm wondering if we can replace PS.: Can you split this PR in order to implement GitHub actions in a dedicated PR? Thanks in advance. |
it seems like a really good idea. could you take care of it?
yes sure! ;) |
Hello,
in order to use your fork here, I would need to advance... We use it here
@DonCallisto