Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): add compatibility to php80 #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JellyBellyDev
Copy link

Hello,
in order to use your fork here, I would need to advance... We use it here

@DonCallisto

composer.json Outdated
@@ -14,8 +14,8 @@
}
],
"require": {
"php": "^7.0",
"phpspec/phpspec": "6.*"
"php": "^7.0 | ^8.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JellyBellyDev
Would you mind to set the lower php version to 7.3 and update travis.yml file accordingly?

Moreover we should test all the things with --PREFER-LOWEST also; would you mind to add it to building matrix too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonCallisto done, but i don't see travis pipeline... could you tell me why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umh, my bad, maybe we didn't setted it up ever.
I will create the travis ci, in order to check if everything's ok, in the upcoming days.
Let's keep in touch. For the moment, thanks for this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled travis for this. Could you please try to trigger the build (maybe by slightly change the commit message?)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! ;)

@JellyBellyDev JellyBellyDev force-pushed the feat/add-compatibility-to-php80 branch from 4081e73 to aa6fcea Compare January 4, 2021 11:45
@JellyBellyDev
Copy link
Author

We must follow this PR carefully! ;)

@JellyBellyDev JellyBellyDev force-pushed the feat/add-compatibility-to-php80 branch from a90a7f6 to 262f0e9 Compare January 5, 2021 09:36
@JellyBellyDev
Copy link
Author

I added also github actions: https://github.com/JellyBellyDev/phpspec-data-provider-extension/actions/runs/463095408

@DonCallisto
Copy link
Member

@JellyBellyDev I'm following this discussion. I'm wondering if we can replace expect assertion inside PHPSpecContext.php with some other libraries (like https://github.com/beberlei/assert) and get rid of that dep in order to move on with this.

PS.: Can you split this PR in order to implement GitHub actions in a dedicated PR? Thanks in advance.

@JellyBellyDev
Copy link
Author

@JellyBellyDev I'm following this discussion. I'm wondering if we can replace expect assertion inside PHPSpecContext.php with some other libraries (like https://github.com/beberlei/assert) and get rid of that dep in order to move on with this.

it seems like a really good idea. could you take care of it?

PS.: Can you split this PR in order to implement GitHub actions in a dedicated PR? Thanks in advance.

yes sure! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants