Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): add compatibility to php80 #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(deps): add compatibility to php80 #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16a69b8
feat(deps): add compatibility to php80
JellyBellyDev Dec 30, 2020
aa6fcea
enhancement minor compatibility to php 7.3
JellyBellyDev Jan 4, 2021
0c3d77b
skip test on DateRange and override use of bossa/phpspec2-expect with…
JellyBellyDev Jan 4, 2021
a5b798f
remove composer self-update by trevis
JellyBellyDev Jan 4, 2021
262f0e9
chore(ci): add github actions CI
JellyBellyDev Jan 5, 2021
ce8fa7c
fix(ci): fix strategy matrix label
JellyBellyDev Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ php:
- 5.6
- 7.0
- 7.1
- 7.2
- 7.3
- 7.4
- 8.0

env:
- COMPOSER_OPTIONS='install --prefer-source'
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
}
],
"require": {
"php": "^7.0",
"phpspec/phpspec": "6.*"
"php": "^7.0 | ^8.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JellyBellyDev
Would you mind to set the lower php version to 7.3 and update travis.yml file accordingly?

Moreover we should test all the things with --PREFER-LOWEST also; would you mind to add it to building matrix too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonCallisto done, but i don't see travis pipeline... could you tell me why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umh, my bad, maybe we didn't setted it up ever.
I will create the travis ci, in order to check if everything's ok, in the upcoming days.
Let's keep in touch. For the moment, thanks for this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled travis for this. Could you please try to trigger the build (maybe by slightly change the commit message?)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! ;)

"phpspec/phpspec": "6.* | 7.*"
},
"require-dev": {
"behat/behat": "^3.1",
Expand Down