-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace contig with region in GWSS functions #691
base: master
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe using a random region instead of a random contig in at least some of the tests would be better. The function random_region_str
from tests/anoph/conftest.py
exists and there are a few examples of use in test_snp_data.py
, for instance.
Just to note that there are other places in the code unrelated to this PR where a random contig is used for a region in testing, e.g.
There might be a valid reason for choosing a random contig over a random region string, I'm not sure, but we could deal with those cases in another PR, in needs be. |
I'm getting |
Resolves #375