Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oopsies #58

Open
wants to merge 1 commit into
base: hauptzweig
Choose a base branch
from
Open

Oopsies #58

wants to merge 1 commit into from

Conversation

malfet
Copy link
Owner

@malfet malfet commented Nov 1, 2023

No description provided.

@malfet
Copy link
Owner Author

malfet commented Nov 1, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Text changes

@malfet
Copy link
Owner Author

malfet commented Nov 1, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Owner Author

malfet commented Nov 1, 2023

@pytorchbot label "topic: not user facing"

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 1, 2023

Didn't find following labels among repository labels: topic: not user facing

@malfet
Copy link
Owner Author

malfet commented Nov 1, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Owner Author

malfet commented Nov 1, 2023

@pytorchbot revert -m "I want it" -c weird

1 similar comment
@malfet
Copy link
Owner Author

malfet commented Nov 1, 2023

@pytorchbot revert -m "I want it" -c weird

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@malfet your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Nov 1, 2023
@pytorchmergebot
Revert "Oopsies (#58)"
f28916b 
This reverts commit f94b276.

Reverted #58 on behalf of https://github.com/malfet due to I want it ([comment](#58 (comment)))
@malfet malfet mentioned this pull request Nov 1, 2023
Closed
@malfet malfet mentioned this pull request Nov 1, 2023
Closed
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Nov 1, 2023
@malfet @pytorchmergebot
[GHF] Bot should reopen PR after revert (#112614)
54c7d0d 
Fixes pytorch/test-infra#4692
Test plan, see malfet/deleteme#58 (comment) / https://github.com/malfet/deleteme/actions/runs/6723011476
Pull Request resolved: #112614
Approved by: https://github.com/seemethere, https://github.com/ezyang
ghstack dependencies: #112613
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@malfet @xuhancn
[GHF] Bot should reopen PR after revert (pytorch#112614)
c8619f9 
Fixes pytorch/test-infra#4692
Test plan, see malfet/deleteme#58 (comment) / https://github.com/malfet/deleteme/actions/runs/6723011476
Pull Request resolved: pytorch#112614
Approved by: https://github.com/seemethere, https://github.com/ezyang
ghstack dependencies: pytorch#112613
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@malfet @Skylion007
[GHF] Bot should reopen PR after revert (pytorch#112614)
371d3c1 
Fixes pytorch/test-infra#4692
Test plan, see malfet/deleteme#58 (comment) / https://github.com/malfet/deleteme/actions/runs/6723011476
Pull Request resolved: pytorch#112614
Approved by: https://github.com/seemethere, https://github.com/ezyang
ghstack dependencies: pytorch#112613
PaliC
PaliC approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@PaliC PaliC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing pr, truly a speciman of beauty !!!!

@PaliC PaliC closed this Dec 5, 2023
@PaliC PaliC reopened this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaliC PaliC PaliC approved these changes

Assignees
No one assigned
Labels
merged reverted topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malfet @pytorchmergebot @PaliC