Skip to content

Conversation

@mariadb-DenisProtivensky
Copy link

@mariadb-DenisProtivensky mariadb-DenisProtivensky commented Oct 23, 2025

  • use shared key for sequence update certification
  • employ native replication's code to apply changes for sequences which handles all corner cases properly
  • fix the tests to allow more transactions using sequences to be accepted

That way the sequence is always updated to the maximum value independent of the order of updates, and shared certification keys allow to improve acceptance ratio of concurrent transactions that use sequences. It's reflected in the test changes.

@codership-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

5 similar comments
@codership-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@codership-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@codership-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@codership-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@codership-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

- use shared key for sequence update certification
- employ native replication's code to apply changes for sequences
which handles all corner cases properly
- fix the tests to allow more transactions using sequences to be
accepted

That way the sequence is always updated to the maximum value
independent of the order of updates, and shared certification keys
allow to improve acceptance ratio of concurrent transactions that
use sequences. It's reflected in the test changes.
Copy link

@janlindstrom janlindstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add comment why you need both assignments and consider changing current code little bit easier to read.

Copy link

@janlindstrom janlindstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can you ask Ramesh to test this branch using multi-master setup with wsrep_slave_threads > 1 and wsrep-debug=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants