Homework #1722
Homework #1722
Conversation
… of the Application.
… of the Application.
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request:
-
Method Naming: The method
returnBall()in theLotteryclass should be renamed togetRandomBall()to align with the task requirements. -
Random Number Range: Ensure that the random number generated for the ball is between 0 and 100 inclusive. Update the code to use
random.nextInt(101). -
Testing in Main Method: The
main()method should create and print three balls, not just one. This is important to fully test the functionality.
Please make these changes to meet the core requirements of the task. Once updated, your code will be in great shape! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
|
Done, please review |
There was a problem hiding this comment.
Review Summary
Great job on implementing the core functionality of the Lottery application! 🎉 However, there are a few critical issues that need your attention to fully meet the task requirements:
-
Method Naming: The method
returnBall()in theLotteryclass should be renamed togetRandomBall()to align with the task requirements. This will ensure consistency and clarity in your code. -
Random Number Range: The random number generation for the ball should include 100 as a possible value. Currently, the implementation uses
random.nextInt(100), which generates numbers from 0 to 99. Please update it torandom.nextInt(101)to cover the full range from 0 to 100 inclusive. -
Testing in Main Method: The
main()method in theApplicationclass should create and print three balls, not just one. This is crucial to fully test the functionality and ensure that your application behaves as expected.
These changes are important for the functionality and correctness of your code. Please review the comments and make the necessary adjustments. Remember, addressing these issues will not only improve your code but also enhance your learning experience. Keep up the good work and continue to learn from these opportunities! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| public class Application { | |||
| public static void main(String[] args) { | |||
| // create three balls using class Lottery and print information about them in console | |||
| Lottery lottery = new Lottery(); | |||
| System.out.println(lottery.returnBall()); | |||
There was a problem hiding this comment.
The method returnBall() should be renamed to getRandomBall() to align with the task requirements. Also, ensure that the main method creates and prints three balls, not just one.
| import java.util.Random; | ||
|
|
||
| public class Lottery { | ||
| public Ball returnBall() { |
There was a problem hiding this comment.
The method returnBall() should be renamed to getRandomBall() to align with the task requirements.
| ColorSupplier colorSupplier = new ColorSupplier(); | ||
| randomBall.setColor(colorSupplier.getRandomColor()); | ||
| Random random = new Random(); | ||
| randomBall.setNumber(random.nextInt(100)); |
There was a problem hiding this comment.
The random number generation should include 100 as a possible value. Use random.nextInt(101) to ensure the range is 0 to 100 inclusive.
No description provided.