Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homework #1722

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/core/basesyntax/Application.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

public class Application {
public static void main(String[] args) {
// create three balls using class Lottery and print information about them in console
Lottery lottery = new Lottery();
System.out.println(lottery.returnBall());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method returnBall() should be renamed to getRandomBall() to align with the task requirements. Also, ensure that the main method creates and prints three balls, not just one.

}
}
27 changes: 27 additions & 0 deletions src/main/java/core/basesyntax/Ball.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package core.basesyntax;

public class Ball {
private String color;
private int number;

public String getColor() {
return color;
}

public int getNumber() {
return number;
}

public void setColor(String color) {
this.color = color;
}

public void setNumber(int number) {
this.number = number;
}

@Override
public String toString() {
return "Ball color is " + color + ", ball number is " + number;
}
}
7 changes: 6 additions & 1 deletion src/main/java/core/basesyntax/ColorSupplier.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
package core.basesyntax;

import java.util.Random;

public class ColorSupplier {
public String getRandomColor() {
return null;
Random random = new Random();
int index = random.nextInt(DiffColors.values().length);
DiffColors color = DiffColors.values()[index];
return color.name();
}
}
9 changes: 9 additions & 0 deletions src/main/java/core/basesyntax/DiffColors.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package core.basesyntax;

public enum DiffColors {
RED,
YELLOW,
BLUE,
GREEN,
BROWN
}
14 changes: 14 additions & 0 deletions src/main/java/core/basesyntax/Lottery.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package core.basesyntax;

import java.util.Random;

public class Lottery {
public Ball returnBall() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method returnBall() should be renamed to getRandomBall() to align with the task requirements.

Ball randomBall = new Ball();
ColorSupplier colorSupplier = new ColorSupplier();
randomBall.setColor(colorSupplier.getRandomColor());
Random random = new Random();
randomBall.setNumber(random.nextInt(100));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The random number generation should include 100 as a possible value. Use random.nextInt(101) to ensure the range is 0 to 100 inclusive.

return randomBall;
}
}
Loading