Done #1733
Done #1733
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 Your code is well-structured and meets all the core requirements. While it's suggested to use a loop for creating multiple Ball objects to enhance code maintainability, this is a minor improvement and doesn't affect the functionality. Keep up the good work and consider this suggestion for future projects to make your code even more efficient! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| Ball[] balls = new Ball[3]; | ||
|
|
||
| for (int i = 0; i < 3; i++) { | ||
| balls[i] = lottery.getRandomBall(); | ||
| System.out.println(balls[i]); | ||
| } |
There was a problem hiding this comment.
we don't need array here, please try to rewrite without it
| WHITE, | ||
| PURPLE | ||
| } | ||
|
|
There was a problem hiding this comment.
let's make sure there's exactly one empty line at the end of each file, you have two here
| public String getRandomColor() { | ||
| return null; | ||
| public Color getRandomColor() { | ||
| int picker = new Random().nextInt(Color.values().length); |
There was a problem hiding this comment.
your code creates new Random instance for each method invocation, let's move it to the class level
| ColorSupplier colorSupplier = new ColorSupplier(); | ||
|
|
||
| Color color = colorSupplier.getRandomColor(); | ||
| int number = new Random().nextInt(101); |
There was a problem hiding this comment.
same for Random here
make 101 a constant
There was a problem hiding this comment.
I made number 101 constant but how i can move this int number = new Random().nextInt(101); to the class level?
| public class ColorSupplier { | ||
| public String getRandomColor() { | ||
| return null; | ||
| private static final Random picker = new Random(); |
There was a problem hiding this comment.
| private static final Random picker = new Random(); | |
| private final Random random = new Random(); |
Don’t make it a static field
|
|
||
| public class Lottery { | ||
| private static final int maxNum = 101; | ||
| private static final Random number = new Random(); |
| private static final Random number = new Random(); | ||
|
|
||
| public Ball getRandomBall() { | ||
| ColorSupplier colorSupplier = new ColorSupplier(); |
There was a problem hiding this comment.
ColorSupplier also should make private final class-level variable
| import java.util.Random; | ||
|
|
||
| public class Lottery { | ||
| private static final int maxNum = 101; |
There was a problem hiding this comment.
| private static final int maxNum = 101; | |
| private static final int MAX_NUMBER = 101; |
use the correct constant style
No description provided.