Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done #1733

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Done #1733

Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/core/basesyntax/Application.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,10 @@
public class Application {
public static void main(String[] args) {
// create three balls using class Lottery and print information about them in console
Lottery lottery = new Lottery();

for (int i = 0; i < 3; i++) {
System.out.println(lottery.getRandomBall());
}
}
}
34 changes: 34 additions & 0 deletions src/main/java/core/basesyntax/Ball.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
package core.basesyntax;

public class Ball {
private Color color;
private int number;

public Ball(Color color, int number) {
this.color = color;
this.number = number;
}

public Color getColor() {
return color;
}

public void setColor(Color color) {
this.color = color;
}

public int getNumber() {
return number;
}

public void setNumber(int number) {
this.number = number;
}

@Override
public String toString() {
return "Ball \n"
+ "color: " + this.color + "\n"
+ "number: " + this.number;
}
}
10 changes: 10 additions & 0 deletions src/main/java/core/basesyntax/Color.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package core.basesyntax;

public enum Color {
RED,
GREEN,
BLUE,
BLACK,
WHITE,
PURPLE
}
8 changes: 6 additions & 2 deletions src/main/java/core/basesyntax/ColorSupplier.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
package core.basesyntax;

import java.util.Random;

public class ColorSupplier {
public String getRandomColor() {
return null;
private static final Random picker = new Random();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private static final Random picker = new Random();
private final Random random = new Random();

Don’t make it a static field


public Color getRandomColor() {
return Color.values()[picker.nextInt(Color.values().length)];
}
}
15 changes: 15 additions & 0 deletions src/main/java/core/basesyntax/Lottery.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package core.basesyntax;

import java.util.Random;

public class Lottery {
private static final int maxNum = 101;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private static final int maxNum = 101;
private static final int MAX_NUMBER = 101;

use the correct constant style

private static final Random number = new Random();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same about Random


public Ball getRandomBall() {
ColorSupplier colorSupplier = new ColorSupplier();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ColorSupplier also should make private final class-level variable

Color color = colorSupplier.getRandomColor();

return new Ball(color, number.nextInt(maxNum));
}
}
Loading