fix invalid boss race in mission data #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix invalid boss race in mission data
tehNinth
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reason i care about this at all is because i am working on a networking library for cubeworld that is very strict about data validity, and it breaks on cuwo servers because of this
it was falsely assumed that
monster_idrefers to the guid of the boss (hence the comment expressing confusion), when it actually represents therace(eg undead) of the boss, which is sometimes used in the mission text on the right side of the screen (eg "defeat the undead in [dungeon]"). since this mission doesn't have such text, it doesn't matter what value is used here so it should at least be a valid one (0-156). i decided to default to 0 which represents a male elf