Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Fix focused publishing #761

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Fix focused publishing #761

merged 2 commits into from
Aug 11, 2023

Conversation

aringenbach
Copy link
Contributor

This change:

  • Fixes an issue around publishing the focused value within view update (i.e. Xcode runtime purple warning)
  • Moves the library iOS requirement to iOS 15 (in order to use FocusState and remove the need of an external focused binding)
  • Adds a UI test for toggling the focus state (i.e. simulates the interaction with a hosting app updating from outside)
  • Revamps a bit how the buttons for debug actions of the example app work to save some place for debug AST / sent message, etc:

Simulator Screenshot - iPhone 14 Pro - 2023-08-11 at 14 11 48

@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.47% 🎉

Comparison is base (555d7f1) 88.38% compared to head (8749483) 89.86%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #761      +/-   ##
============================================
+ Coverage     88.38%   89.86%   +1.47%     
============================================
  Files           150      113      -37     
  Lines         17638    16222    -1416     
  Branches        836      606     -230     
============================================
- Hits          15590    14578    -1012     
+ Misses         1841     1624     -217     
+ Partials        207       20     -187     
Flag Coverage Δ
uitests 80.51% <100.00%> (+5.39%) ⬆️
uitests-android ?
uitests-ios 80.51% <100.00%> (-0.13%) ⬇️
unittests 88.55% <0.00%> (+1.01%) ⬆️
unittests-android ?
unittests-ios 76.25% <0.00%> (+0.74%) ⬆️
unittests-rust 89.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ents/WysiwygComposerView/WysiwygComposerView.swift 76.85% <100.00%> (-1.82%) ⬇️

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aringenbach aringenbach merged commit 6db80b1 into main Aug 11, 2023
9 checks passed
@aringenbach aringenbach deleted the aringenbach/fix-focus-publishing branch August 11, 2023 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants