Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Simplify the interface of search_for_device #3748

Conversation

andybalaam
Copy link
Contributor

A tiny change to this method interface to make it easier to call from different parts of the code.

Part of #3546

@andybalaam andybalaam marked this pull request as ready for review July 23, 2024 12:57
@andybalaam andybalaam requested a review from a team as a code owner July 23, 2024 12:57
@andybalaam andybalaam requested review from jmartinesp and removed request for a team July 23, 2024 12:57
Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't know if I have enough permissions to for my review to actually unblock this 😅 .

@poljar
Copy link
Contributor

poljar commented Jul 23, 2024

LGTM, I don't know if I have enough permissions to for my review to actually unblock this 😅 .

You do, from this week on.

@andybalaam andybalaam merged commit c9e95cf into andybalaam/db-schema-for-retry-time Jul 23, 2024
3 checks passed
@andybalaam andybalaam deleted the andybalaam/search-for-device-uses-userid branch July 23, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants