Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Disable share_pos() inside RoomListService #4256

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Nov 13, 2024

@Hywan Hywan requested a review from a team as a code owner November 13, 2024 08:15
@Hywan Hywan requested review from bnjbvr and removed request for a team November 13, 2024 08:15
This patch disables the call to `share_pos()` inside the
`RoomListService` because it creates slowness we need to investigate.
@Hywan Hywan enabled auto-merge (rebase) November 13, 2024 08:22
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.90%. Comparing base (9dd2d5e) to head (c11af7c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4256      +/-   ##
==========================================
- Coverage   84.95%   84.90%   -0.05%     
==========================================
  Files         274      274              
  Lines       29768    29768              
==========================================
- Hits        25288    25275      -13     
- Misses       4480     4493      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan Hywan merged commit a920c3f into matrix-org:main Nov 13, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PaginationStatusListener isn't sending paginating until the pagination is finished.
2 participants