Upgrade to work with Umbraco 9.0.0+ / net5.0+ #30
Conversation
| { | ||
| public void Initialize() | ||
| { | ||
| RouteTable.Routes.IgnoreStandardExclusions(); |
There was a problem hiding this comment.
I couldn't find a netcore equivalent to this and the package seems to work in v11 without it - not sure if it's needed in netcore?
| { | ||
| internal class HeadRestAuthorizeAttribute : AuthorizeAttribute | ||
| { | ||
| protected override void HandleUnauthorizedRequest(AuthorizationContext filterContext) |
There was a problem hiding this comment.
This code has been moved directly into the AuthorizedHeadRestController
| _config = config; | ||
| } | ||
|
|
||
| protected override IPublishedContent FindContent(RequestContext requestContext, UmbracoContext umbracoContext) |
There was a problem hiding this comment.
This code has been moved directly into the HeadRest.cs class
| @@ -76,5 +92,46 @@ private static void ValidateConfig(HeadRestConfig config) | |||
| throw new Exception("ViewModelMappings can not be null"); | |||
| } | |||
| } | |||
|
|
|||
| private static IPublishedContent FindContent(ActionExecutingContext actionExecutingContext) | |||
There was a problem hiding this comment.
This has been moved from the old HeadRestRouteHandler
src/Our.Umbraco.HeadRest/HeadRest.cs
Outdated
| config.BasePath = basePath; | ||
| config.RootNodeXPath = rootNodeXPath; | ||
| ConfigureEndpoint(config); | ||
| var config = new HeadRestConfig(options) |
There was a problem hiding this comment.
It was quite tricky getting hold of the _mapper at this point, so I changed it to pass in the old options and copy the values in the constructor instead.
|
|
||
| namespace Our.Umbraco.HeadRest.Web.Mvc | ||
| { | ||
| internal class HeadRestResult : JsonNetResult | ||
| internal class HeadRestResult : ActionResult |
There was a problem hiding this comment.
JsonNetResult is no longer available, so I copied the code from it and adapted it for netcore to make HeadRestResult work the same way and serialize using the serializer settings we want it to.
|
|
||
| namespace Our.Umbraco.HeadRest.Web.Routing | ||
| { | ||
| internal class HeadRestUrlProvider : DefaultUrlProvider | ||
| internal class HeadRestUrlProvider : IUrlProvider |
There was a problem hiding this comment.
The DefaultUrlProvider has a different constructor in v9 than it does in v10+ which makes it tricky to inherit from without creating different versions of the code.
Rather than try to have 2 different versions of the code/releases/packages with 2 different constructors, I've updated the code to implement the IUrlProvider instead and injected the DefaultUrlProvider so that we can still fall back to use its methods for non-HeadRest URLs.
… used by Umbraco v9
…rt of the serialization
|
Update: the site we're migrating from v8 > v11 is in PR and includes this version of HeadRest. It should be going through QA very soon so I'll update this with any bugfixes we make before marking it as ready for review! |
| context.HttpContext.Response.StatusCode = 401; | ||
|
|
||
| // This doesn't exist in netcore - do we need it? | ||
| // context.HttpContext.Response.SuppressFormsAuthenticationRedirect = true; |
There was a problem hiding this comment.
This doesn't exist in netcore - do we need it?
|
Another update - our v11 project has been through QA and is going live tomorrow. I'll give it a week to settle in and then submit the PR if everything seems stable |
|
Whoops - a bit more than a week...sorry about that! Everything seems to be working on live, so I think it seems good to go (bearing in mind we don't use all the features of HeadRest). Is this a PR you think would be worth the effort to merge in/maintain? If so I can update some of the docs before submitting...if not, no worries 😄 |
could you share how to apply the .net core version to Umbraco 11 project? |
Hi @luonghongthuan - apologies for the delayed reply, I've been away on leave! It's been quite a while since we did the work, but I've just gone through the readme and updated it with how the configuration has changed - you can see the differences in the PR or view the updated readme here. You can't install the package from nuget as it only exists in this PR. Instead you'll need to clone/pull down the project locally and either:
Hope that helps! |
…rt of serialization
Yet another update - we recently upgraded our v11 project to v13 and HeadRest is still working without any changes needed! I also realised that I made a small change back when we upgraded to v11 which didn't get pushed, so I've just pushed that too. |
Upgrade to work with v9+ - WIP
We currently have a v8 project that we're upgrading to v11 - as Umbraco won't be releasing a headless API until v12, we thought it would be worth upgrading HeadRest to work with v11 first, and then downgrade the package versions to v9 to see if it still worked.
This is the work so far - I've got it working on a sample v11 Umbraco project, but we'll be integrating it into our upgraded v11 project in the next few weeks.
I'm raising this draft PR to see if this is something that you might be interested in - no worries if not...especially as headless is coming into core in v12!