-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to work with Umbraco 9.0.0+ / net5.0+ #30
Open
tristanjthompson
wants to merge
8
commits into
mattbrailsford:develop
Choose a base branch
from
tristanjthompson:feature/upgrade-to-work-with-v9-to-v11
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8ae83ac
Upgrade to work with a minimum of Umbraco 9.0.0 / net5.0
tristanjthompson 56a7919
Formatting tweaks
tristanjthompson ecbe0c3
Downgrade Microsoft.AspNetCore.Authorization version to match version…
tristanjthompson 99334e1
Prevent NullReferenceException in UrlProvider when root node can't be…
tristanjthompson 9b990d1
Update StreamWriter settings so that it doesn't emit a BOM at the sta…
tristanjthompson f776893
Update readme with Umbraco 9.0+ configuration
tristanjthompson abf0185
Update StreamWriter settings so that it doesn't emit a BOM at the sta…
tristanjthompson f28f019
Readme tweaks
tristanjthompson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,24 @@ | ||
using Our.Umbraco.HeadRest.Mapping; | ||
using Microsoft.Extensions.DependencyInjection; | ||
using Our.Umbraco.HeadRest.Mapping; | ||
using Our.Umbraco.HeadRest.Web.Routing; | ||
using Umbraco.Core; | ||
using Umbraco.Core.Composing; | ||
using Umbraco.Core.Mapping; | ||
using Umbraco.Web.Routing; | ||
using Umbraco.Cms.Core.Composing; | ||
using Umbraco.Cms.Core.DependencyInjection; | ||
using Umbraco.Cms.Core.Mapping; | ||
using Umbraco.Cms.Core.Routing; | ||
|
||
namespace Our.Umbraco.HeadRest.Composing | ||
{ | ||
public class HeadRestComposer : IUserComposer | ||
public class HeadRestComposer : IComposer | ||
{ | ||
public void Compose(Composition composition) | ||
public void Compose(IUmbracoBuilder builder) | ||
{ | ||
composition.WithCollectionBuilder<UrlProviderCollectionBuilder>() | ||
builder.WithCollectionBuilder<UrlProviderCollectionBuilder>() | ||
.InsertBefore<DefaultUrlProvider, HeadRestUrlProvider>(); | ||
|
||
composition.WithCollectionBuilder<MapDefinitionCollectionBuilder>() | ||
builder.WithCollectionBuilder<MapDefinitionCollectionBuilder>() | ||
.Add<HeadRestMapDefinition>(); | ||
|
||
composition.Register<HeadRest>(); | ||
|
||
composition.Components() | ||
.Append<HeadRestComponent>(); | ||
builder.Services.AddTransient<HeadRest>(); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been moved from the old
HeadRestRouteHandler