chore(codeowners): Update Owner Team #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahar4
requested review from
RomanBrodetski,
perekopskiy,
Deniallugo and
popzxc
as code owners
RomanBrodetski
approved these changes
Oct 2, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 31.59% 31.50% -0.09%
==========================================
Files 477 477
Lines 25429 25429
==========================================
- Hits 8034 8012 -22
- Misses 17395 17417 +22 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
ilitteri
pushed a commit
that referenced
this pull request
Feb 23, 2024
…mode and Rollup mode (#121) * Add example: build_commit_tx_input_data_is_correct (fails) * Abstract normal_checker_function test * Abstract checker_processes_pre_boojum_batches * Abstract checker_functions_after_snapshot_recovery test * Abstract checker_functions_after_snapshot_recovery test * Remove unnecessary auxiliar function * Fix all the failing tests * Use test_helpers module * Remove ValidiumModeL1BatchCommitDataGenerator fix * Add bytes pubdata with 0 value for the encoding (#136)
ilitteri
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Add example: build_commit_tx_input_data_is_correct (fails) * Abstract normal_checker_function test * Abstract checker_processes_pre_boojum_batches * Abstract checker_functions_after_snapshot_recovery test * Abstract checker_functions_after_snapshot_recovery test * Remove unnecessary auxiliar function * Fix all the failing tests * Use test_helpers module * Remove ValidiumModeL1BatchCommitDataGenerator fix * Add bytes pubdata with 0 value for the encoding (#136) * Fix unnecessary pub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR replaces the core team in codeowners with the newly created era-reviewers team.
Why ❔
To tighten who can approve PRs and not spam the rest.
Checklist
zk fmtandzk lint.