Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community supported README: legal disclaimer #61

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

cwarnermm
Copy link
Contributor

Added legal disclaimer to README, as requested by Product.

@cwarnermm cwarnermm added the 2: Dev Review Requires review by a core committer label Nov 1, 2023
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until the discussion in https://community.mattermost.com/private-core/pl/51hbdxfn7tbbuboys4siw8peea has been resolved

README.md Outdated Show resolved Hide resolved
@cwarnermm cwarnermm requested a review from hanzei December 8, 2023 15:46
@cwarnermm
Copy link
Contributor Author

@hanzei - Legal's updated guidance and language for the legal disclaimer for community-supported integrations has been applied to this PR.

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Dec 12, 2023
@cwarnermm cwarnermm enabled auto-merge (squash) December 12, 2023 18:34
@cwarnermm
Copy link
Contributor Author

@hanzei - This PR is ready for your final approval.

1 similar comment
@cwarnermm
Copy link
Contributor Author

@hanzei - This PR is ready for your final approval.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7fde170) 64.75% compared to head (a72d76c) 64.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   64.75%   64.75%           
=======================================
  Files          17       17           
  Lines        1444     1444           
=======================================
  Hits          935      935           
  Misses        465      465           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanzei
Copy link
Contributor

hanzei commented Jan 8, 2024

The linter issues are broking this PR. @ayusht2810 Would you please fix them in a separate PR?

@hanzei hanzei merged commit 080e592 into master Jan 23, 2024
4 checks passed
@hanzei hanzei deleted the servicenow-virtual-agent-legal branch January 23, 2024 11:34
@hanzei
Copy link
Contributor

hanzei commented Jan 23, 2024

Thanks @phoinixgrr for unblocking CI 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants