Slug based deploys #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor PendingMigrationCheck so that #last_deployed_commit is an input instead of lookup. This simplifies PendingMigrationCheck and allows users of the configuration option `migration_check` to have a simpler interface to implement.
I thought I might need it when originallycut and pasted from SourceControl.
…to slug_based_deploys
|
Thank you very much for taking the time to add this feature. I'll go through it as soon as I can. I appreciate that you're able to use it already for real-world applications. |
|
just pinging to see if we can get some movement on this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my PR for supporting slug based deploys on Heroku. It required a minor refactoring of
PendingMigrationCheckto make the interface simpler so you can provide your ownmigration_checkclass.The README has usage docs on how to use slug-based deploys and run migrations using the
migration_checkoption.I'm using it right now for multiple production apps, so it's got real-world usage. I'm open to further refinements, so let me know what you think.