Update Vale to latest #155
Conversation
| @@ -5,5 +5,6 @@ | |||
| "esbonio.sphinx.confDir": "${workspaceFolder}/docs", | |||
| "restructuredtext.pythonRecommendation.disabled": true, | |||
| "restructuredtext.preview.name": "sphinx", | |||
| "gitlens.showWhatsNewAfterUpgrades": false | |||
| "gitlens.showWhatsNewAfterUpgrades": false, | |||
| "restructuredtext.linter.rstcheck.executablePath": "rstcheck" | |||
There was a problem hiding this comment.
Fixes the rstcheck vscode integration. Source: vscode-restructuredtext/vscode-restructuredtext#400 (comment)
However, the maintainers mention that rstcheck shouldn't be necessary anymore as Esbonio reports most of the issues too: vscode-restructuredtext/vscode-restructuredtext#400 (comment). I'm happy to remove it altogether but Esbonio certainly doesn't catch everything yet.
|
When I tried to load this on Gitpod, I got the following in a popup:
I have to select okay to proceed. Hopefully this also means we can close this PR which I was not able to get to actually work properly, as it kept throwing errors. If the first comment is okay then this is good to go! |
|
Going to close this one as we've done it in other PRs which didn't break stuff 🚀 |
We're quite a few versions behind. Let's go from 2.20.2 (Sept 14 2022) to 2.28.3. Changelog: https://github.com/errata-ai/vale/releases
This also fixes the Gitpod/VS Code integration by bumping the Esbonio language server to the latest version 🚀